From d4944607ab2a2b607dfa579dc8c878ee3730baea Mon Sep 17 00:00:00 2001
From: Sean <skessler1964@gmail.com>
Date: Tue, 8 Apr 2025 12:54:22 -0400
Subject: [PATCH] More optimizations and code cleanup

---
 .../Generator/GainLoss/ActiveGainLossGenerator.cs      |  1 -
 .../Generator/GainLoss/GainLossGenerator.cs            |  2 --
 .../Generator/GainLoss/GainLossGeneratorCum.cs         | 10 ++--------
 README.md                                              |  5 +++++
 4 files changed, 7 insertions(+), 11 deletions(-)

diff --git a/MarketData/MarketDataLib/Generator/GainLoss/ActiveGainLossGenerator.cs b/MarketData/MarketDataLib/Generator/GainLoss/ActiveGainLossGenerator.cs
index b6ceb35..49fc148 100755
--- a/MarketData/MarketDataLib/Generator/GainLoss/ActiveGainLossGenerator.cs
+++ b/MarketData/MarketDataLib/Generator/GainLoss/ActiveGainLossGenerator.cs
@@ -24,7 +24,6 @@ namespace MarketData.Generator.GainLoss
       if (null == portfolioTrades || 0 == portfolioTrades.Count) return null;
       LocalPriceCache.GetInstance().Add(portfolioTrades);
       DateTime minTradeDate = portfolioTrades.GetMinTradeDate();
-//      DateTime maxDate = PricingDA.GetLatestDate();
       DateTime maxDate=LocalPriceCache.GetInstance().GetLatestDate();
       if(null!=maxDateRef)maxDate=maxDateRef.Value;
       Dictionary<DateTime,GainLossItem> gainLoss = new Dictionary<DateTime, GainLossItem>();
diff --git a/MarketData/MarketDataLib/Generator/GainLoss/GainLossGenerator.cs b/MarketData/MarketDataLib/Generator/GainLoss/GainLossGenerator.cs
index 29ceedd..695a93c 100755
--- a/MarketData/MarketDataLib/Generator/GainLoss/GainLossGenerator.cs
+++ b/MarketData/MarketDataLib/Generator/GainLoss/GainLossGenerator.cs
@@ -24,7 +24,6 @@ namespace MarketData.Generator.GainLoss
       if (null == portfolioTrades || 0 == portfolioTrades.Count) return null;
       LocalPriceCache.GetInstance().Add(portfolioTrades);
       DateTime minTradeDate = portfolioTrades.GetMinTradeDate();
-//      DateTime maxDate = PricingDA.GetLatestDate();
       DateTime maxDate=LocalPriceCache.GetInstance().GetLatestDate();
       if(null!=maxDateRef)maxDate=maxDateRef.Value;
       Dictionary<DateTime,TotalGainLossItem> gainLossCollection = new Dictionary<DateTime, TotalGainLossItem>();
@@ -77,7 +76,6 @@ namespace MarketData.Generator.GainLoss
       if (null == portfolioTrades || 0 == portfolioTrades.Count) return null;
       LocalPriceCache.GetInstance().Add(portfolioTrades);
       DateTime minTradeDate = portfolioTrades.GetMinTradeDate();
-//      DateTime maxDate = PricingDA.GetLatestDate();
       DateTime maxDate=LocalPriceCache.GetInstance().GetLatestDate();
       if(null!=maxDateRef)maxDate=maxDateRef.Value;
       Dictionary<DateTime,TotalGainLossItem> gainLossCollection = new Dictionary<DateTime, TotalGainLossItem>();
diff --git a/MarketData/MarketDataLib/Generator/GainLoss/GainLossGeneratorCum.cs b/MarketData/MarketDataLib/Generator/GainLoss/GainLossGeneratorCum.cs
index c917efe..27cad84 100755
--- a/MarketData/MarketDataLib/Generator/GainLoss/GainLossGeneratorCum.cs
+++ b/MarketData/MarketDataLib/Generator/GainLoss/GainLossGeneratorCum.cs
@@ -24,7 +24,7 @@ namespace MarketData.Generator.GainLoss
       {
         if(!ValidatePortfolioTrades(portfolioTrades))return null;
         DateTime minDate=portfolioTrades.GetMinTradeDate();
-        DateTime maxDate=PricingDA.GetLatestDate();
+        DateTime maxDate = LocalPriceCache.GetInstance().GetLatestDate();
         if(null!=maxDateRef) maxDate=maxDateRef.Value;
         double prevGainLoss=double.NaN;
         List<DateTime> historicalDates=dateGenerator.GenerateHistoricalDates(minDate,maxDate);
@@ -103,9 +103,8 @@ namespace MarketData.Generator.GainLoss
       {
         if(!ValidatePortfolioTrades(portfolioTrades)) return null;
         DateTime minDate=portfolioTrades.Min(x => x.TradeDate);
-        DateTime maxDate=PricingDA.GetLatestDate();
+        DateTime maxDate = LocalPriceCache.GetInstance().GetLatestDate();
         double prevGainLoss=double.NaN;
-//        LocalPriceCache.GetInstance().RemoveDate(maxDate);
         List<DateTime> historicalDates=dateGenerator.GenerateHistoricalDates(minDate,maxDate);
 
         foreach(DateTime currentDate in historicalDates)
@@ -124,11 +123,6 @@ namespace MarketData.Generator.GainLoss
           foreach(PortfolioTrade openPosition in openPositions)
           {
             exposure+=openPosition.Shares*openPosition.Price;
-            //if(!LocalPriceCache.GetInstance().ContainsPrice(openPosition.Symbol,currentDate))
-            //{
-            //  Prices prices=PricingDA.GetPricesForward(openPosition.Symbol,currentDate,90);
-            //  LocalPriceCache.GetInstance().Add(prices);
-            //}
             Price price=LocalPriceCache.GetInstance().GetPrice(openPosition.Symbol,currentDate);
             if(null==price)
             {
diff --git a/README.md b/README.md
index b1aca59..7148f22 100644
--- a/README.md
+++ b/README.md
@@ -6,6 +6,11 @@ TO-DO
   dotnet add package Microsoft.AspNet.WebApi.SelfHost --version 5.3.0
   dotnet add package System.ServiceModel.Primitives  --version 4.0.0
 
+Git Delete Remote Branch
+git push <remote_name> --delete <branch_name>
+git push origin --delete <branch_name>
+
+
 Please use the Microsoft.AspNet.WebApi.OwinSelfHost package for new projects.
 Microsoft.AspNet.WebApi.OwinSelfHost