From c4d2da2522842e4428a5efc856fcbe788a64645e Mon Sep 17 00:00:00 2001 From: Sean Date: Fri, 12 Dec 2025 10:01:43 -0500 Subject: [PATCH] Remove StopLimit "Active" --- PortfolioManager/Models/CMTPositionModelCollection.cs | 4 ++-- PortfolioManager/Models/MGSHPositionModelCollection.cs | 4 ++-- PortfolioManager/Renderers/BollingerBandRenderer.cs | 2 +- PortfolioManager/ViewModels/CMTrendViewModel.cs | 2 -- PortfolioManager/ViewModels/MGSHMomentumViewModel.cs | 2 -- 5 files changed, 5 insertions(+), 9 deletions(-) diff --git a/PortfolioManager/Models/CMTPositionModelCollection.cs b/PortfolioManager/Models/CMTPositionModelCollection.cs index ba41276..6ff6005 100644 --- a/PortfolioManager/Models/CMTPositionModelCollection.cs +++ b/PortfolioManager/Models/CMTPositionModelCollection.cs @@ -270,7 +270,7 @@ namespace PortfolioManager.Models { if(!IsActivePosition) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Blue); if(!Utility.IsEpoch(position.LastStopAdjustment)) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black); // if we have a trailing stop then we are no longer using the initial stop - StopLimit stopLimit=PortfolioDA.GetStopLimit(position.Symbol); + StopLimit stopLimit=StopLimitDA.GetStopLimit(position.Symbol); if(null==stopLimit||!stopLimit.StopPrice.Equals(Math.Round(position.InitialStopLimit,2))) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple); if(currentPriceLow<=position.InitialStopLimit) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red); return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black); @@ -295,7 +295,7 @@ namespace PortfolioManager.Models { return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red); } - StopLimit stopLimit=PortfolioDA.GetStopLimit(position.Symbol); + StopLimit stopLimit=StopLimitDA.GetStopLimit(position.Symbol); if(null==stopLimit || !stopLimit.StopPrice.Equals(Math.Round(position.TrailingStopLimit,2))) { return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple); diff --git a/PortfolioManager/Models/MGSHPositionModelCollection.cs b/PortfolioManager/Models/MGSHPositionModelCollection.cs index c345aa8..eb2644b 100644 --- a/PortfolioManager/Models/MGSHPositionModelCollection.cs +++ b/PortfolioManager/Models/MGSHPositionModelCollection.cs @@ -542,7 +542,7 @@ namespace PortfolioManager.Models { if (!IsActivePosition) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Blue); if (!Utility.IsEpoch(position.LastStopAdjustment)) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black); // if we have a trailing stop then we are no longer using the initial stop - StopLimit stopLimit = PortfolioDA.GetStopLimit(position.Symbol); + StopLimit stopLimit = StopLimitDA.GetStopLimit(position.Symbol); if (null == stopLimit || !stopLimit.StopPrice.Equals(Math.Round(position.InitialStopLimit, 2))) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple); if (currentPriceLow <= position.InitialStopLimit) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red); return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black); @@ -569,7 +569,7 @@ namespace PortfolioManager.Models { return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red); } - StopLimit stopLimit = PortfolioDA.GetStopLimit(position.Symbol); + StopLimit stopLimit = StopLimitDA.GetStopLimit(position.Symbol); if (null == stopLimit || !stopLimit.StopPrice.Equals(Math.Round(position.TrailingStopLimit, 2))) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple); return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black); } diff --git a/PortfolioManager/Renderers/BollingerBandRenderer.cs b/PortfolioManager/Renderers/BollingerBandRenderer.cs index ce04a82..f8b264e 100644 --- a/PortfolioManager/Renderers/BollingerBandRenderer.cs +++ b/PortfolioManager/Renderers/BollingerBandRenderer.cs @@ -146,7 +146,7 @@ namespace PortfolioManager.Renderers MDTrace.WriteLine(LogLevel.DEBUG,$"[SetData] ENTER"); this.selectedSymbol = selectedSymbol; this.selectedDayCount = selectedDayCount; - stopLimit = PortfolioDA.GetStopLimit(selectedSymbol); + stopLimit = StopLimitDA.GetStopLimit(selectedSymbol); portfolioTrades = PortfolioDA.GetTradesSymbol(selectedSymbol); portfolioTradesLots = LotAggregator.CombineLots(portfolioTrades); diff --git a/PortfolioManager/ViewModels/CMTrendViewModel.cs b/PortfolioManager/ViewModels/CMTrendViewModel.cs index 9edd370..971ec59 100644 --- a/PortfolioManager/ViewModels/CMTrendViewModel.cs +++ b/PortfolioManager/ViewModels/CMTrendViewModel.cs @@ -416,7 +416,6 @@ namespace PortfolioManager.ViewModels initialStopLimit.StopPrice=selectedPosition.InitialStopLimit; initialStopLimit.StopType=StopLimitConstants.STOP_QUOTE; initialStopLimit.EffectiveDate=selectedPosition.PurchaseDate; - initialStopLimit.Active=1; marketDataModelStopLimits.Add(initialStopLimit); foreach(MarketData.Generator.Model.StopLimit stopLimit in stopLimits) @@ -427,7 +426,6 @@ namespace PortfolioManager.ViewModels marketDataModelStopLimit.StopPrice=stopLimit.NewStop; marketDataModelStopLimit.StopType=StopLimitConstants.STOP_QUOTE; marketDataModelStopLimit.EffectiveDate=stopLimit.AnalysisDate; - marketDataModelStopLimit.Active=1; marketDataModelStopLimits.Add(marketDataModelStopLimit); } return marketDataModelStopLimits; diff --git a/PortfolioManager/ViewModels/MGSHMomentumViewModel.cs b/PortfolioManager/ViewModels/MGSHMomentumViewModel.cs index 07d5721..7b5e871 100644 --- a/PortfolioManager/ViewModels/MGSHMomentumViewModel.cs +++ b/PortfolioManager/ViewModels/MGSHMomentumViewModel.cs @@ -216,7 +216,6 @@ namespace PortfolioManager.ViewModels initialStopLimit.StopPrice = selectedPosition.InitialStopLimit; initialStopLimit.StopType = StopLimitConstants.STOP_QUOTE; initialStopLimit.EffectiveDate = selectedPosition.PurchaseDate; - initialStopLimit.Active = 1; marketDataModelStopLimits.Add(initialStopLimit); foreach (MarketData.Generator.Model.StopLimit stopLimit in stopLimits) @@ -227,7 +226,6 @@ namespace PortfolioManager.ViewModels marketDataModelStopLimit.StopPrice = stopLimit.NewStop; marketDataModelStopLimit.StopType = StopLimitConstants.STOP_QUOTE; marketDataModelStopLimit.EffectiveDate = stopLimit.AnalysisDate; - marketDataModelStopLimit.Active = 1; marketDataModelStopLimits.Add(marketDataModelStopLimit); }