Code cleanup.

sstp/socketserver.cpp

@@ -32,8 +32,6 @@ SocketServer::SocketServer(int port)
 // bind socket to network address and port  
   mInternalSocketAddress.sin_family = AF_INET;
   mInternalSocketAddress.sin_addr.s_addr=INADDR_ANY;
-
-
   mInternalSocketAddress.sin_port = htons(mListenPort);
   result = ::bind(mSocketFileDescriptor,(struct sockaddr*)&mInternalSocketAddress,sizeof(mInternalSocketAddress));
   if(result)
@@ -47,9 +45,14 @@ SocketServer::SocketServer(int port)
 /// @brief Close down the listener
 SocketServer::~SocketServer()
 {
+  std::cout << "~SocketServer" << std::endl;
+  std::cout << "shutdownConnectionReceivers" << std::endl;
   shutdownConnectionReceivers();
+  std::cout << "join" << std::endl;
   join();    // Then join all socket threads
+  std::cout << "close" << std::endl;
   close();   // close the listener socket
+  std::cout << "~SocketServer, done" << std::endl;
   
 }
 
@@ -110,9 +113,6 @@ void SocketServer::listen(void)
     pSocketConnectionReceiver = ::new SocketConnectionReceiver(socket, internalSocketAddress);
     pSocketConnectionReceiver.disposition(PointerDisposition::Delete);
     mExecutionThreads.push_back(std::thread(&SocketConnectionReceiver::threadFunction, *pSocketConnectionReceiver, 0));
-
-//    SocketConnectionReceiver socketConnectionReceiver(socket, internalSocketAddress);
-//    mExecutionThreads.push_back(std::thread(&SocketConnectionReceiver::threadFunction, &socketConnectionReceiver, 0));
   }
 }
 
@@ -120,9 +120,8 @@ void SocketServer::listen(void)
 /// @param  
 void SocketServer::close(void)
 {
-  if(-1!=mSocketFileDescriptor)
-  {
-    ::close(mSocketFileDescriptor);
-    mSocketFileDescriptor=-1;
-  }
+  if(-1==mSocketFileDescriptor)return;
+  std::cout << "SocketServer::close, closing socket" << std::endl;
+  ::close(mSocketFileDescriptor);
+  mSocketFileDescriptor=-1;
 }