Added locks around MySql.Open() which was causing issues with concurrency againt the connection pool.

There was a need to serialize access to the connection pool.
This commit is contained in:
2025-02-22 22:19:12 -05:00
parent eda09a7f4f
commit 4e89253fd1

View File

@@ -24,6 +24,8 @@ namespace MarketData.Utils
/// <param name="password">users password.</param> /// <param name="password">users password.</param>
/// <returns>SqlConnection or null on error.</returns> /// <returns>SqlConnection or null on error.</returns>
public static MySqlConnection CreateMySqlConnection(string datasource,string port,string database,string username,string password) public static MySqlConnection CreateMySqlConnection(string datasource,string port,string database,string username,string password)
{
lock(typeof(SqlUtils))
{ {
try try
{ {
@@ -53,10 +55,13 @@ namespace MarketData.Utils
return null; return null;
} }
} }
}
/// <summary>CreateSqlConnection - Creates an SQL connection.</summary> /// <summary>CreateSqlConnection - Creates an SQL connection.</summary>
/// <param name="datasource">the datasource.</param> /// <param name="datasource">the datasource.</param>
/// <returns>SqlConnection or null on error.</returns> /// <returns>SqlConnection or null on error.</returns>
public static MySqlConnection CreateMySqlConnection(DataSourceEx datasource) public static MySqlConnection CreateMySqlConnection(DataSourceEx datasource)
{
lock(typeof(SqlUtils))
{ {
try try
{ {
@@ -77,7 +82,6 @@ namespace MarketData.Utils
connectionString=sb.ToString(); connectionString=sb.ToString();
MySqlConnection connection=new MySqlConnection(connectionString); MySqlConnection connection=new MySqlConnection(connectionString);
connection.Open(); connection.Open();
//SetConnectionCollation(connection);
return connection; return connection;
} }
catch(SqlException exception) catch(SqlException exception)
@@ -86,23 +90,8 @@ namespace MarketData.Utils
return null; return null;
} }
} }
/// <summary>SetConnectionCollation - Set database connection collation. Have to do for MySql 8.0.33</summary> }
/// <returns>void.</returns>
//public static void SetConnectionCollation(MySqlConnection sqlConnection)
//{
// MySqlCommand sqlCommand=null;
// try
// {
// sqlCommand=sqlConnection.CreateCommand();
// sqlCommand.CommandText="SET collation_connection='utf8mb4_general_ci';";
// sqlCommand.ExecuteNonQuery();
// sqlCommand.Dispose();
// }
// catch(Exception exception)
// {
// MDTrace.WriteLine(LogLevel.DEBUG,exception.ToString());
// }
//}
public static String FormatDate(DateTime dateTime) public static String FormatDate(DateTime dateTime)
{ {
return Utility.DateTimeToStringYYYYHMMHDD(dateTime); return Utility.DateTimeToStringYYYYHMMHDD(dateTime);