Sean/marketdata
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Added locks around MySql.Open() which was causing issues with concurrency againt the connection pool.

Browse Source 
There was a need to serialize access to the connection pool.
This commit is contained in:
Sean
2025-02-22 22:19:12 -05:00
parent eda09a7f4f
commit 4e89253fd1
1 changed files with 56 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

123
MarketDataLib/Utility/SQLUtils.cs
View File

@@ -25,32 +25,35 @@ namespace MarketData.Utils
/// <returns>SqlConnection or null on error.</returns> /// <returns>SqlConnection or null on error.</returns>
public static MySqlConnection CreateMySqlConnection(string datasource,string port,string database,string username,string password) public static MySqlConnection CreateMySqlConnection(string datasource,string port,string database,string username,string password)
{ {
try lock(typeof(SqlUtils))
{ {
String connectionString=null; try
StringBuilder sb=new StringBuilder(); {
sb.Append("server=").Append(datasource).Append("; "); String connectionString=null;
sb.Append("user id=").Append(username).Append("; "); StringBuilder sb=new StringBuilder();
sb.Append("password=").Append(password).Append("; "); sb.Append("server=").Append(datasource).Append("; ");
sb.Append("database=").Append(database).Append("; "); sb.Append("user id=").Append(username).Append("; ");
sb.Append("SslMode=").Append("None").Append("; "); sb.Append("password=").Append(password).Append("; ");
sb.Append("pooling=").Append("true").Append(";"); sb.Append("database=").Append(database).Append("; ");
sb.Append("MinimumPoolSize=").Append(MIN_POOL_SIZE).Append(";"); sb.Append("SslMode=").Append("None").Append("; ");
sb.Append("MaximumPoolSize=").Append(MAX_POOL_SIZE).Append(";"); sb.Append("pooling=").Append("true").Append(";");
sb.Append("allow user variables=").Append("true").Append("; "); sb.Append("MinimumPoolSize=").Append(MIN_POOL_SIZE).Append(";");
sb.Append("default command timeout=").Append("300").Append("; "); sb.Append("MaximumPoolSize=").Append(MAX_POOL_SIZE).Append(";");
sb.Append("connect timeout=").Append("300").Append(";"); sb.Append("allow user variables=").Append("true").Append("; ");
sb.Append("charset=").Append("utf8mb4").Append(" "); sb.Append("default command timeout=").Append("300").Append("; ");
connectionString=sb.ToString(); sb.Append("connect timeout=").Append("300").Append(";");
MySqlConnection connection=new MySqlConnection(connectionString); sb.Append("charset=").Append("utf8mb4").Append(" ");
connection.Open(); connectionString=sb.ToString();
//SetConnectionCollation(connection); MySqlConnection connection=new MySqlConnection(connectionString);
return connection; connection.Open();
} //SetConnectionCollation(connection);
catch(SqlException exception) return connection;
{ }
MDTrace.WriteLine(LogLevel.DEBUG,exception.ToString()); catch(SqlException exception)
return null; {
MDTrace.WriteLine(LogLevel.DEBUG,exception.ToString());
return null;
}
} }
} }
/// <summary>CreateSqlConnection - Creates an SQL connection.</summary> /// <summary>CreateSqlConnection - Creates an SQL connection.</summary>
@@ -58,51 +61,37 @@ namespace MarketData.Utils
/// <returns>SqlConnection or null on error.</returns> /// <returns>SqlConnection or null on error.</returns>
public static MySqlConnection CreateMySqlConnection(DataSourceEx datasource) public static MySqlConnection CreateMySqlConnection(DataSourceEx datasource)
{ {
try lock(typeof(SqlUtils))
{ {
String connectionString=null; try
StringBuilder sb=new StringBuilder(); {
sb.Append("server=").Append(datasource.Datasource).Append("; "); String connectionString=null;
sb.Append("user id=").Append(datasource.Username).Append("; "); StringBuilder sb=new StringBuilder();
sb.Append("password=").Append(datasource.Password).Append("; "); sb.Append("server=").Append(datasource.Datasource).Append("; ");
sb.Append("database=").Append(datasource.Database).Append("; "); sb.Append("user id=").Append(datasource.Username).Append("; ");
sb.Append("SslMode=").Append("None").Append("; "); sb.Append("password=").Append(datasource.Password).Append("; ");
sb.Append("pooling=").Append("true").Append(";"); sb.Append("database=").Append(datasource.Database).Append("; ");
sb.Append("allow user variables=").Append("true").Append("; "); sb.Append("SslMode=").Append("None").Append("; ");
sb.Append("default command timeout=").Append("300").Append("; "); sb.Append("pooling=").Append("true").Append(";");
sb.Append("connect timeout=").Append("300").Append(";"); sb.Append("allow user variables=").Append("true").Append("; ");
sb.Append("MinimumPoolSize=").Append(MIN_POOL_SIZE).Append(";"); sb.Append("default command timeout=").Append("300").Append("; ");
sb.Append("MaximumPoolSize=").Append(MAX_POOL_SIZE).Append(";"); sb.Append("connect timeout=").Append("300").Append(";");
sb.Append("charset=").Append("utf8mb4").Append(" "); sb.Append("MinimumPoolSize=").Append(MIN_POOL_SIZE).Append(";");
connectionString=sb.ToString(); sb.Append("MaximumPoolSize=").Append(MAX_POOL_SIZE).Append(";");
MySqlConnection connection=new MySqlConnection(connectionString); sb.Append("charset=").Append("utf8mb4").Append(" ");
connection.Open(); connectionString=sb.ToString();
//SetConnectionCollation(connection); MySqlConnection connection=new MySqlConnection(connectionString);
return connection; connection.Open();
} return connection;
catch(SqlException exception) }
{ catch(SqlException exception)
MDTrace.WriteLine(LogLevel.DEBUG,exception.ToString()); {
return null; MDTrace.WriteLine(LogLevel.DEBUG,exception.ToString());
return null;
}
} }
} }
/// <summary>SetConnectionCollation - Set database connection collation. Have to do for MySql 8.0.33</summary>
/// <returns>void.</returns>
//public static void SetConnectionCollation(MySqlConnection sqlConnection)
//{
// MySqlCommand sqlCommand=null;
// try
// {
// sqlCommand=sqlConnection.CreateCommand();
// sqlCommand.CommandText="SET collation_connection='utf8mb4_general_ci';";
// sqlCommand.ExecuteNonQuery();
// sqlCommand.Dispose();
// }
// catch(Exception exception)
// {
// MDTrace.WriteLine(LogLevel.DEBUG,exception.ToString());
// }
//}
public static String FormatDate(DateTime dateTime) public static String FormatDate(DateTime dateTime)
{ {
return Utility.DateTimeToStringYYYYHMMHDD(dateTime); return Utility.DateTimeToStringYYYYHMMHDD(dateTime);