From 8d9f47b395e9d79e85931e509fac1efa09ed47ae Mon Sep 17 00:00:00 2001
From: Sean Kessler <skessler1964@gmail.com>
Date: Wed, 28 Feb 2024 09:52:54 -0500
Subject: [PATCH] Refactor

---
 MarketDataLib/DataAccess/InsiderTransactionDA.cs  | 8 ++++----
 MarketDataLib/Helper/InsiderTransactionsParser.cs | 3 ++-
 MarketDataLib/Helper/MarketDataHelper.cs          | 2 +-
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/MarketDataLib/DataAccess/InsiderTransactionDA.cs b/MarketDataLib/DataAccess/InsiderTransactionDA.cs
index b9cafb1..779113a 100644
--- a/MarketDataLib/DataAccess/InsiderTransactionDA.cs
+++ b/MarketDataLib/DataAccess/InsiderTransactionDA.cs
@@ -130,12 +130,12 @@ namespace MarketData.DataAccess
             MDTrace.WriteLine(LogLevel.DEBUG,String.Format("Collection already contains a value for Form:{0} SECAccessionNumber:{1} FormRowNumber:{2}",
               insiderTransaction.Form,insiderTransaction.SECAccessionNumber,insiderTransaction.FormRowNumber));
             
-            MDTrace.WriteLine(LogLevel.DEBUG,String.Format("Item attempting to add: InsiderName:{0} OwnershipType:{1} Securities:{2} NatureOfTransaction:{3} NumberOrValueAcquiredDisposed:{4} Price:{5} FilingDate:{6} TransactionDate:{7}",
-              insiderTransaction.InsiderName,insiderTransaction.OwnershipType,insiderTransaction.Securities,insiderTransaction.NatureOfTransaction,insiderTransaction.NumberOrValueAcquiredDisposed,insiderTransaction.Price,
+            MDTrace.WriteLine(LogLevel.DEBUG,String.Format("Item attempting to add: Symbol:{0} InsiderName:{1} OwnershipType:{2} Securities:{3} NatureOfTransaction:{4} NumberOrValueAcquiredDisposed:{5} Price:{7} FilingDate:{7} TransactionDate:{8}",
+              insiderTransaction.Symbol, insiderTransaction.InsiderName,insiderTransaction.OwnershipType,insiderTransaction.Securities,insiderTransaction.NatureOfTransaction,insiderTransaction.NumberOrValueAcquiredDisposed,insiderTransaction.Price,
               Utility.DateTimeToStringMMHDDHYYYY(insiderTransaction.FilingDate),Utility.DateTimeToStringMMSDDSYYYY(insiderTransaction.TransactionDate)));
 
-            MDTrace.WriteLine(LogLevel.DEBUG,String.Format("Item already in collection: InsiderName:{0} OwnershipType:{1} Securities:{2} NatureOfTransaction:{3} NumberOrValueAcquiredDisposed:{4} Price:{5} FilingDate:{6} TransactionDate:{7}",
-              insiderTransaction.InsiderName,insiderTransaction.OwnershipType,insiderTransaction.Securities,insiderTransaction.NatureOfTransaction,insiderTransaction.NumberOrValueAcquiredDisposed,insiderTransaction.Price,
+            MDTrace.WriteLine(LogLevel.DEBUG,String.Format("Item already in collection: Symbol:{0} InsiderName:{1} OwnershipType:{2} Securities:{3} NatureOfTransaction:{4} NumberOrValueAcquiredDisposed:{5} Price:{6} FilingDate:{7} TransactionDate:{8}",
+              insiderTransaction.Symbol,insiderTransaction.InsiderName,insiderTransaction.OwnershipType,insiderTransaction.Securities,insiderTransaction.NatureOfTransaction,insiderTransaction.NumberOrValueAcquiredDisposed,insiderTransaction.Price,
               Utility.DateTimeToStringMMHDDHYYYY(insiderTransaction.FilingDate),Utility.DateTimeToStringMMSDDSYYYY(insiderTransaction.TransactionDate)));
 
             MDTrace.WriteLine(LogLevel.DEBUG,"*********************************************************************************************************");
diff --git a/MarketDataLib/Helper/InsiderTransactionsParser.cs b/MarketDataLib/Helper/InsiderTransactionsParser.cs
index ae4cc15..aec86aa 100644
--- a/MarketDataLib/Helper/InsiderTransactionsParser.cs
+++ b/MarketDataLib/Helper/InsiderTransactionsParser.cs
@@ -151,10 +151,11 @@ namespace MarketData.Helper
       for(int index=0;index<tables.Count;index++)
       {
         HtmlNodeCollection collection = tables[index].SelectNodes(".//tr");
+        if(null==collection)continue;
         for(int itemIndex=0;itemIndex<collection.Count;itemIndex++)
         {
           String marker=collection[itemIndex].InnerText;
-          if(marker.StartsWith(startsWith))
+          if(null!=marker && marker.StartsWith(startsWith))
           {
             return tables[index];
           }
diff --git a/MarketDataLib/Helper/MarketDataHelper.cs b/MarketDataLib/Helper/MarketDataHelper.cs
index 41ea6c7..ad191d0 100644
--- a/MarketDataLib/Helper/MarketDataHelper.cs
+++ b/MarketDataLib/Helper/MarketDataHelper.cs
@@ -1241,7 +1241,7 @@ namespace MarketData.Helper
 // ***************************************************************************************************************************************************************************************
 // ************************************ S E C   F I L I N G S  -  F O R M  4  &  F O R M 5  - F O R  I N S I D E R  T R A N S A C T I O N S  S E C . G O V     ***************************S
 // ***************************************************************************************************************************************************************************************
-    public static InsiderTransactions GetInsiderTransactions(String symbol,int timePeriodDays=30)
+    public static InsiderTransactions GetInsiderTransactions(String symbol,int timePeriodDays=15)
     {
       MemoryStream memoryStream = null;
       HttpNetResponse httpNetResponse=null;