Improve BollingerBandRendering

PortfolioManager/Cache/ImageCache.cs

@@ -57,6 +57,7 @@ namespace PortfolioManager.Cache
     {
       lock (thisLock)
       {
+        DisposeBitmaps();
         imageCache = new Dictionary<ImageType, Bitmap>();
       }
     }
@@ -66,22 +67,30 @@ namespace PortfolioManager.Cache
       lock (thisLock)
       {
         if (null == imageCacheInstance) return;
-        List<Bitmap> bitmaps = imageCache.Values.ToList();
-        foreach (Bitmap bitmap in bitmaps)
-        {
-          bitmap.Dispose();
-        }
+        DisposeBitmaps();
         imageCache = null;
         imageCacheInstance = null;
       }
     }
-
-    public IImage GetImage(ImageCache.ImageType imageType)
+    
+    private void DisposeBitmaps()
     {
-      lock(this)
+      if(null == imageCache)return;
+      List<Bitmap> bitmaps = imageCache.Values.ToList();
+      foreach (Bitmap bitmap in bitmaps)
       {
-        return imageCache[imageType];
+        bitmap.Dispose();
       }
     }
+
+    public IImage GetImage(ImageType imageType)
+    {
+        lock(thisLock)
+        {
+          if (imageCache == null)throw new ObjectDisposedException(nameof(ImageCache));
+          if (!imageCache.TryGetValue(imageType, out var bitmap))throw new KeyNotFoundException($"Image {imageType} not found in cache.");
+          return bitmap;
+        }
+    }    
   }
 }

PortfolioManager/Cache/SymbolCache.cs

@@ -10,7 +10,8 @@ namespace PortfolioManager.Cache
   public class SymbolCache : IDisposable
   {
     private List<String> symbolCache=new List<String>();
-    private Object thisLock=new Object();
+    private readonly Object thisLock=new Object();
+    private readonly Object fetchLock = new Object();
     private Thread cacheMonitorThread=null;
     private volatile bool threadRun=true;
     private int cacheRefreshAfter=60000;        // Invalidate cache after
@@ -36,31 +37,42 @@ namespace PortfolioManager.Cache
         symbolCache=new List<string>();
       }
     }
+
     public void Dispose()
     {
       lock(thisLock)
       {
-	    if(null==symbolCacheInstance || false==threadRun)return;
+			  if(null==symbolCacheInstance || false==threadRun)return;
         threadRun=false;
-        if(null!=cacheMonitorThread)
-        {
-          MDTrace.WriteLine(LogLevel.DEBUG,String.Format("[SymbolCache:Dispose]Thread state is {0}.  Joining main thread...",Utility.ThreadStateToString(cacheMonitorThread)));
-          cacheMonitorThread.Join(5000);
-          cacheMonitorThread=null;
-          MDTrace.WriteLine(LogLevel.DEBUG,"[SymbolCache:Dispose] End.");
-        }
         symbolCacheInstance=null;
       }
+      if(null!=cacheMonitorThread)
+      {
+        MDTrace.WriteLine(LogLevel.DEBUG,String.Format("[SymbolCache:Dispose]Thread state is {0}.  Joining main thread...",Utility.ThreadStateToString(cacheMonitorThread)));
+        cacheMonitorThread.Join(5000);
+        cacheMonitorThread=null;
+        MDTrace.WriteLine(LogLevel.DEBUG,"[SymbolCache:Dispose] End.");
+      }
     }
 
     public List<String> GetSymbols()
     {
-      lock(this)
+      lock(thisLock)
       {
-        if(0==symbolCache.Count)symbolCache=PricingDA.GetSymbols();
-        return symbolCache;
+        if(symbolCache.Count>0)return new List<string>(symbolCache);
+      }
+      lock(fetchLock)
+      {
+        List<String> symbols = PricingDA.GetSymbols();
+        lock(thisLock)
+        {
+          if(symbolCache.Count>0)return new List<string>(symbolCache);
+          symbolCache=new List<String>(symbols);
+          return new List<string>(symbols);
+        }
       }
     }
+
     private void ThreadProc()
     {
       int quantums=0;
@@ -68,16 +80,18 @@ namespace PortfolioManager.Cache
       while(threadRun)
       {
         Thread.Sleep(quantumInterval);
+        if(!threadRun)break;
         quantums+=quantumInterval;
         if(quantums>cacheRefreshAfter)
         {
           quantums=0;
+          List<String> symbols = PricingDA.GetSymbols();
           lock(thisLock)
           {
-            symbolCache=PricingDA.GetSymbols();
+            symbolCache=new List<string>(symbols);
           }
         }
       }
     }
   }
-}
+}

PortfolioManager/Models/CMTPositionModelCollection.cs

@@ -270,7 +270,7 @@ namespace PortfolioManager.Models
       {
         if(!IsActivePosition) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Blue);
         if(!Utility.IsEpoch(position.LastStopAdjustment)) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black);  // if we have a trailing stop then we are no longer using the initial stop
-        StopLimit stopLimit=StopLimitDA.GetStopLimit(position.Symbol);
+        StopLimit stopLimit=StopLimitDA.GetStopLimit(position.Symbol,position.Shares);
         if(null==stopLimit||!stopLimit.StopPrice.Equals(Math.Round(position.InitialStopLimit,2))) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple);
         if(currentPriceLow<=position.InitialStopLimit) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red);
         return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black);
@@ -295,7 +295,7 @@ namespace PortfolioManager.Models
         {
           return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red);
         }
-        StopLimit stopLimit=StopLimitDA.GetStopLimit(position.Symbol);
+        StopLimit stopLimit=StopLimitDA.GetStopLimit(position.Symbol,position.Shares);
         if(null==stopLimit || !stopLimit.StopPrice.Equals(Math.Round(position.TrailingStopLimit,2))) 
         {
           return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple);

PortfolioManager/Models/GainLossModel.cs

@@ -36,17 +36,17 @@ namespace PortfolioManager.Models
       return compositeDataSource;
     }
 
-    public static CompositeDataSource CreateCompositeDataSource(DateTime xSource, double ySource)
-    {
-      if (Utility.IsEpoch(xSource)) return Empty();
-      SortedDateTimeDataAdapter sortedDateTimeDataAdapter = new SortedDateTimeDataAdapter();
-      sortedDateTimeDataAdapter.Add(xSource, ySource);
-      CompositeDataSource compositeDataSource = new CompositeDataSource()
-      {
-        DataAdapter = sortedDateTimeDataAdapter
-      };
-      return compositeDataSource;      
-    }    
+    // public static CompositeDataSource CreateCompositeDataSource(DateTime xSource, double ySource)
+    // {
+    //   if (Utility.IsEpoch(xSource)) return Empty();
+    //   SortedDateTimeDataAdapter sortedDateTimeDataAdapter = new SortedDateTimeDataAdapter();
+    //   sortedDateTimeDataAdapter.Add(xSource, ySource);
+    //   CompositeDataSource compositeDataSource = new CompositeDataSource()
+    //   {
+    //     DataAdapter = sortedDateTimeDataAdapter
+    //   };
+    //   return compositeDataSource;      
+    // }    
 
     // This is the active gain/loss as number or percent.
     public static CompositeDataSource GainLoss(ModelPerformanceSeries gainLossList, bool useGainLoss)

PortfolioManager/Models/MGSHPositionModelCollection.cs

@@ -542,7 +542,7 @@ namespace PortfolioManager.Models
             {
                 if (!IsActivePosition) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Blue);
                 if (!Utility.IsEpoch(position.LastStopAdjustment)) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black);  // if we have a trailing stop then we are no longer using the initial stop
-                StopLimit stopLimit = StopLimitDA.GetStopLimit(position.Symbol);
+                StopLimit stopLimit = StopLimitDA.GetStopLimit(position.Symbol,position.Shares);
                 if (null == stopLimit || !stopLimit.StopPrice.Equals(Math.Round(position.InitialStopLimit, 2))) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple);
                 if (currentPriceLow <= position.InitialStopLimit) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red);
                 return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black);
@@ -569,7 +569,7 @@ namespace PortfolioManager.Models
                 {
                     return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Red);
                 }
-                StopLimit stopLimit = StopLimitDA.GetStopLimit(position.Symbol);
+                StopLimit stopLimit = StopLimitDA.GetStopLimit(position.Symbol,position.Shares);
                 if (null == stopLimit || !stopLimit.StopPrice.Equals(Math.Round(position.TrailingStopLimit, 2))) return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Purple);
                 return BrushCollection.GetContextBrush(BrushCollection.BrushColor.Black);
             }

PortfolioManager/Models/StopLimitCompositeModel.cs

@@ -3,6 +3,7 @@ using System.Collections.Generic;
 using System.Linq;
 using Eremex.AvaloniaUI.Charts;
 using MarketData.MarketDataModel;
+using MarketData.Utils;
 using PortfolioManager.DataSeriesViewModels;
 
 namespace PortfolioManager.Models
@@ -37,5 +38,25 @@ namespace PortfolioManager.Models
         };
         return compositeDataSource;
     }
+    
+    public static CompositeDataSource CreateCompositeDataSource(DateTime xSource,StopLimits stopLimits)
+    {
+      if (null == stopLimits || 0 == stopLimits.Count) return Empty();
+      foreach(StopLimit stopLimit in stopLimits)
+      {
+          stopLimit.EffectiveDate = xSource;
+      }
+      SortedDateTimeDataAdapter sortedDateTimeDataAdapter = new SortedDateTimeDataAdapter();
+      List<StopLimit> sortedStopLimits = stopLimits.OrderBy(x => x.EffectiveDate).ToList();
+      foreach (StopLimit stopLimit in sortedStopLimits)
+      {
+        sortedDateTimeDataAdapter.Add(stopLimit.EffectiveDate, stopLimit.StopPrice);
+      }
+        CompositeDataSource compositeDataSource = new CompositeDataSource()
+        {
+            DataAdapter = sortedDateTimeDataAdapter
+        };
+        return compositeDataSource;   
+    }       
   }
 }

PortfolioManager/Renderers/BollingerBandRenderer.cs

@@ -40,7 +40,7 @@ namespace PortfolioManager.Renderers
       private bool showInsiderTransactions = true;
       private bool showLeastSquares = true;
       private bool syncTradeToBand = true;
-      private StopLimit stopLimit = default;               // StopLimits that the renderer has located using StopLimitDA
+      private StopLimits internalStopLimits = default;               // StopLimits that the renderer has located using StopLimitDA
       private StopLimits externalStopLimits = default;     // StopLimits that are provided to the renderer externally by a model
       private PortfolioTrades portfolioTrades = default;
       private PortfolioTrades portfolioTradesLots = default;
@@ -55,6 +55,13 @@ namespace PortfolioManager.Renderers
         Plotter = plotter ?? throw new ArgumentNullException(nameof(plotter));
         PropertyChanged += OnBollingerBandRendererPropertyChanged;
       }
+      
+      private DateTime EarliestBollingerBandDate {get;set;}   // This gets set when the bollinger band is generated
+      
+      private bool IsVisible(DateTime date)
+      {
+        return syncTradeToBand || date >= EarliestBollingerBandDate;
+      }      
 
       private void OnBollingerBandRendererPropertyChanged(Object sender, PropertyChangedEventArgs eventArgs)
       {
@@ -94,10 +101,12 @@ namespace PortfolioManager.Renderers
     {
       lock(Plotter.Plot.Sync)
       {
+        int bollingerBandMovingAverageDays = 20;
         MDTrace.WriteLine(LogLevel.DEBUG,$"[SetData] ENTER");
         this.selectedSymbol = selectedSymbol;
         this.selectedDayCount = selectedDayCount;
-        stopLimit = StopLimitDA.GetStopLimit(selectedSymbol);
+        
+        internalStopLimits = StopLimitDA.GetStopLimits(selectedSymbol);
         portfolioTrades = PortfolioDA.GetTradesSymbol(selectedSymbol);
         portfolioTradesLots = LotAggregator.CombineLots(portfolioTrades);
 
@@ -105,13 +114,18 @@ namespace PortfolioManager.Renderers
         if (null != portfolioTrades && 0 != portfolioTrades.Count)
         {
           DateGenerator dateGenerator = new DateGenerator();
-          DateTime earliestTrade = portfolioTrades[0].TradeDate;
-          earliestTrade = earliestTrade.AddDays(-30);
+          DateTime earliestTrade = portfolioTrades.First().TradeDate;  // portfolio trades are ordered with earliest trade in the lowest index
+          earliestTrade = dateGenerator.GenerateHistoricalDate(earliestTrade, bollingerBandMovingAverageDays);  // cover the moving average lag in the band
           int daysBetween = dateGenerator.DaysBetween(earliestTrade, DateTime.Now);
-          if (daysBetween < selectedDayCount || !syncTradeToBand) prices = PricingDA.GetPrices(selectedSymbol, selectedDayCount);
-          else prices = PricingDA.GetPrices(selectedSymbol, earliestTrade);
-
-          DateTime earliestInsiderTransactionDate = dateGenerator.GenerateFutureBusinessDate(prices[prices.Count - 1].Date, 30);
+          if (daysBetween < selectedDayCount || !syncTradeToBand)
+          {
+             prices = PricingDA.GetPrices(selectedSymbol, selectedDayCount + bollingerBandMovingAverageDays);
+          }
+          else 
+          {
+            prices = PricingDA.GetPrices(selectedSymbol, earliestTrade);
+          }
+          DateTime earliestInsiderTransactionDate = dateGenerator.GenerateFutureBusinessDate(prices.Last().Date, 30);
           insiderTransactionSummaries = InsiderTransactionDA.GetInsiderTransactionSummaries(selectedSymbol, earliestInsiderTransactionDate);
 
           // calculate the break even price on the open trades for this symbol
@@ -122,8 +136,8 @@ namespace PortfolioManager.Renderers
 
           if (!syncTradeToBand)
           {
-            DateTime earliestPricingDate = prices[prices.Count - 1].Date;
-            earliestPricingDate = earliestPricingDate.AddDays(30);
+            DateTime earliestPricingDate = prices.Last().Date;
+            earliestPricingDate = dateGenerator.GenerateHistoricalDate(earliestPricingDate, bollingerBandMovingAverageDays);
             IEnumerable<PortfolioTrade> tradesInRange = (from portfolioTrade in portfolioTradesLots where portfolioTrade.TradeDate >= earliestPricingDate select portfolioTrade);
             portfolioTrades = new PortfolioTrades();
             foreach (PortfolioTrade portfolioTrade in tradesInRange) portfolioTrades.Add(portfolioTrade);
@@ -132,15 +146,16 @@ namespace PortfolioManager.Renderers
         }
         else
         {
-          prices = PricingDA.GetPrices(selectedSymbol, selectedDayCount);
+          prices = PricingDA.GetPrices(selectedSymbol, selectedDayCount + bollingerBandMovingAverageDays);
           if (null != prices && 0 != prices.Count)
           {
             DateGenerator dateGenerator = new DateGenerator();
-            DateTime earliestInsiderTransactionDate = dateGenerator.GenerateFutureBusinessDate(prices[prices.Count - 1].Date, 30);
+            DateTime earliestInsiderTransactionDate = dateGenerator.GenerateFutureBusinessDate(prices.Last().Date, 30);
             insiderTransactionSummaries = InsiderTransactionDA.GetInsiderTransactionSummaries(selectedSymbol, earliestInsiderTransactionDate);
           }
         }
-        bollingerBands = BollingerBandGenerator.GenerateBollingerBands(prices);
+        bollingerBands = BollingerBandGenerator.GenerateBollingerBands(prices, bollingerBandMovingAverageDays);
+        EarliestBollingerBandDate = bollingerBands.Min(x=>x.Date);
         textMarkerManager.Clear();
         CalculateOffsets();
         GenerateBollingerBands();
@@ -153,7 +168,7 @@ namespace PortfolioManager.Renderers
         MDTrace.WriteLine(LogLevel.DEBUG,$"[SetData] LEAVE");
       }
     }
-
+    
     /// <summary>
     /// These offsets are used to place markers relative to the area in which the graph occupies.
     /// </summary>
@@ -235,118 +250,134 @@ namespace PortfolioManager.Renderers
       imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, image);
     }
 
-    /// <summary>
-    /// Generate Stop Limits
-    /// </summary>
     private void GenerateStopLimits()
     {
-      if (null == externalStopLimits && null == zeroPrice) return;
-      if (null != externalStopLimits)
-      {
-        StopLimits = StopLimitCompositeModel.CreateCompositeDataSource(externalStopLimits);
-      }
-      else if (null != stopLimit && null != zeroPrice)
-      {
-        StopLimits = GainLossModel.CreateCompositeDataSource(zeroPrice.Date, stopLimit.StopPrice);
-      }
-      (DateTime[] dates, double[] values) = StopLimits.ToXYData();
+        if (externalStopLimits == null && zeroPrice == null) return;
 
-      // Add the image markers
-      Image imageStopLimitMarker = TextMarkerImageGenerator.ToSPImage(ImageCache.GetInstance().GetImage(ImageCache.ImageType.RedTriangleUp));
-      for (int index = 0; index < dates.Length; index++)
-      {
-        DateTime date = dates[index];
-        double value = values[index];
-        Coordinates coordinates = new Coordinates(date.ToOADate(), value);
-        ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, imageStopLimitMarker, SizeFactor.Normal);
-      }
+        // Create the composite data source
+        if (externalStopLimits != null)
+            StopLimits = StopLimitCompositeModel.CreateCompositeDataSource(externalStopLimits);
+        else if (internalStopLimits != null && zeroPrice != null)
+            StopLimits = StopLimitCompositeModel.CreateCompositeDataSource(zeroPrice.Date, internalStopLimits);
 
-      if(!showTradeLabels)return;
+        (DateTime[] dates, double[] values) = StopLimits.ToXYData();
 
-      // Add the text marker
-      if (null != externalStopLimits)
-      {
-        for (int index = 0; index < externalStopLimits.Count; index++)
+        // Add the image markers
+        Image imageStopLimitMarker = TextMarkerImageGenerator.ToSPImage(
+            ImageCache.GetInstance().GetImage(ImageCache.ImageType.RedTriangleUp));
+
+        for (int i = 0; i < dates.Length; i++)
         {
-          StopLimit limit = externalStopLimits[index];
+            DateTime date = dates[i];
 
-          StringBuilder sb = new StringBuilder();
-          sb.Append(limit.StopType).Append(" ");
-          sb.Append(Utility.FormatCurrency(limit.StopPrice));
-          if (index == externalStopLimits.Count - 1)
-          {
-            Price latestPrice = prices[0];
-            double percentOffsetFromLow = ((latestPrice.Low - limit.StopPrice) / limit.StopPrice);
-            sb.Append(" (").Append(percentOffsetFromLow > 0 ? "+" : "").Append(Utility.FormatPercent(percentOffsetFromLow)).Append(")");
-          }
-          Image image = TextMarkerImageGenerator.GenerateImage(sb.ToString(), FontFactor.FontSize);
-          Coordinates coordinates = new Coordinates(limit.EffectiveDate.ToOADate(), 
-               limit.StopPrice - offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+            if (!IsVisible(date))
+                continue;
 
-          coordinates = textMarkerManager.GetBestMarkerLocation(coordinates.X, coordinates.Y,offsets, offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
-
-          ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, image);
+            double value = values[i];
+            Coordinates coordinates = new Coordinates(date.ToOADate(), value);
+            Plotter.Plot.Add.ImageMarker(coordinates, imageStopLimitMarker, SizeFactor.Normal);
         }
-      }
-      else
-      {
-        if (null == zeroPrice) return;
-        if (null == stopLimit || null == zeroPrice) return;
+
+        if (!showTradeLabels) return;
+
         Price latestPrice = prices[0];
-        double percentOffsetFromLow = ((latestPrice.Low - stopLimit.StopPrice) / stopLimit.StopPrice);
 
-        StringBuilder sb = new StringBuilder();
-        sb.Append(stopLimit.StopType).Append(" ");
-        sb.Append(Utility.FormatCurrency(stopLimit.StopPrice));
-        sb.Append(" (").Append(percentOffsetFromLow > 0 ? "+" : "").Append(Utility.FormatPercent(percentOffsetFromLow)).Append(")");
-        Image image = TextMarkerImageGenerator.GenerateImage(sb.ToString(), FontFactor.FontSize);
-        Coordinates coordinates = new Coordinates(latestPrice.Date.ToOADate() - offsets.Offset(OffsetDictionary.OffsetType.HorizontalOffset3PC), 
-            stopLimit.StopPrice - offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+        // Helper to draw text markers
+        void DrawTextMarker(StopLimit limit, bool isLast)
+        {
+            if (!IsVisible(limit.EffectiveDate)) return;
 
-        coordinates = textMarkerManager.GetBestMarkerLocation(coordinates.X, coordinates.Y,offsets, offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+            StringBuilder sb = new StringBuilder();
+            sb.Append(limit.StopType).Append(" ");
+            sb.Append(Utility.FormatCurrency(limit.StopPrice));
 
-        ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, image);
-      }
-    }
+            if (isLast)
+            {
+                double percentOffsetFromLow = (latestPrice.Low - limit.StopPrice) / limit.StopPrice;
+                sb.Append(" (")
+                  .Append(percentOffsetFromLow > 0 ? "+" : "")
+                  .Append(Utility.FormatPercent(percentOffsetFromLow))
+                  .Append(")");
+            }
 
+            Image image = TextMarkerImageGenerator.GenerateImage(sb.ToString(), FontFactor.FontSize);
+            Coordinates coordinates = new Coordinates(
+                limit.EffectiveDate.ToOADate(),
+                limit.StopPrice - offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+
+            coordinates = textMarkerManager.GetBestMarkerLocation(
+                coordinates.X, coordinates.Y, offsets, offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+
+            Plotter.Plot.Add.ImageMarker(coordinates, image);
+        }
+
+        // Draw external or internal stop limits
+        if (externalStopLimits != null)
+        {
+            for (int i = 0; i < externalStopLimits.Count; i++)
+                DrawTextMarker(externalStopLimits[i], i == externalStopLimits.Count - 1);
+        }
+        else if (internalStopLimits != null && zeroPrice != null)
+        {
+            for (int i = 0; i < internalStopLimits.Count; i++)
+                DrawTextMarker(internalStopLimits[i], i == internalStopLimits.Count - 1);
+        }
+    } 
+       
     /// <summary>
     /// Generate Trade Points
     /// </summary>
     private void GenerateTradePoints()
     {
-      if (null == portfolioTradesLots || 0 == portfolioTradesLots.Count) return;
+        if (portfolioTradesLots == null || portfolioTradesLots.Count == 0) return;
 
-      // Here we add the image markers     
-      Image tradePointMarker = TextMarkerImageGenerator.ToSPImage(ImageCache.GetInstance().GetImage(ImageCache.ImageType.YellowTriangleUp));
-      for (int index = 0; index < portfolioTradesLots.Count; index++)
-      {
-        PortfolioTrade portfolioTrade = portfolioTradesLots[index];
-        Coordinates coordinates = new Coordinates(portfolioTrade.TradeDate.ToOADate(), portfolioTrade.Price);
-        ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, tradePointMarker, SizeFactor.Normal);
-      }
+        // Add the image markers
+        Image tradePointMarker = TextMarkerImageGenerator.ToSPImage(
+            ImageCache.GetInstance().GetImage(ImageCache.ImageType.YellowTriangleUp));
 
-      if (showTradeLabels)
-      {
-        // This adds the text markers      
-        for (int index = 0; index < portfolioTradesLots.Count; index++)
+        foreach (var portfolioTrade in portfolioTradesLots)
         {
-          PortfolioTrade portfolioTrade = portfolioTradesLots[index];
-          StringBuilder sb = new StringBuilder();
-          sb.Append(portfolioTrade.BuySell.Equals("B") ? "Buy " : "Sell ");
-          sb.Append(Utility.FormatNumber(portfolioTrade.Shares));
-          sb.Append("@");
-          sb.Append(Utility.FormatCurrency(portfolioTrade.Price));
-          Image image = TextMarkerImageGenerator.GenerateImage(sb.ToString(), FontFactor.FontSize);
-          Coordinates coordinates = new Coordinates(portfolioTrade.TradeDate.ToOADate(), 
-             portfolioTrade.Price - offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+            if (!IsVisible(portfolioTrade.TradeDate))
+                continue;
 
-          coordinates = textMarkerManager.GetBestMarkerLocation(coordinates.X, coordinates.Y,offsets, offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+            Coordinates coordinates = new Coordinates(
+                portfolioTrade.TradeDate.ToOADate(), 
+                portfolioTrade.Price);
 
-          ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, image);
+            ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, tradePointMarker, SizeFactor.Normal);
+        }
+
+        if (!showTradeLabels) return;
+
+        // Add the text markers
+        foreach (var portfolioTrade in portfolioTradesLots)
+        {
+            if (!IsVisible(portfolioTrade.TradeDate))
+                continue;
+
+            StringBuilder sb = new StringBuilder();
+            sb.Append(portfolioTrade.BuySell.Equals("B") ? "Buy " : "Sell ");
+            sb.Append(Utility.FormatNumber(portfolioTrade.Shares));
+            sb.Append("@");
+            sb.Append(Utility.FormatCurrency(portfolioTrade.Price));
+
+            Image image = TextMarkerImageGenerator.GenerateImage(sb.ToString(), FontFactor.FontSize);
+
+            Coordinates coordinates = new Coordinates(
+                portfolioTrade.TradeDate.ToOADate(),
+                portfolioTrade.Price - offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+
+            coordinates = textMarkerManager.GetBestMarkerLocation(
+                coordinates.X,
+                coordinates.Y,
+                offsets,
+                offsets.Offset(OffsetDictionary.OffsetType.VerticalOffset6P5PC));
+
+            ImageMarker imageMarker = Plotter.Plot.Add.ImageMarker(coordinates, image);
         }
-      }
     }
 
+
     /// <summary>
     /// Generate Insider Transactions
     /// </summary>
@@ -361,8 +392,8 @@ namespace PortfolioManager.Renderers
       // get the maximum date in the bollinger band series
       DateTime maxBollingerDate = (from BollingerBandElement bollingerBandElement in bollingerBands select bollingerBandElement.Date).Max();
       // ensure that the insider transactions are clipped to the bollingerband max date.  There are some items in insider transaction summaries (options dated in the future) that will throw the graphic out of proportion
-      InsiderTransactionSummaries disposedSummaries = new InsiderTransactionSummaries((from InsiderTransactionSummary insiderTransactionSummary in insiderTransactionSummaries where insiderTransactionSummary.NumberOfSharesAcquiredDisposed < 0 && insiderTransactionSummary.TransactionDate.Date <= maxBollingerDate select insiderTransactionSummary).ToList());
-      InsiderTransactionSummaries acquiredSummaries = new InsiderTransactionSummaries((from InsiderTransactionSummary insiderTransactionSummary in insiderTransactionSummaries where insiderTransactionSummary.NumberOfSharesAcquiredDisposed > 0 && insiderTransactionSummary.TransactionDate.Date <= maxBollingerDate select insiderTransactionSummary).ToList());
+      InsiderTransactionSummaries disposedSummaries = new InsiderTransactionSummaries((from InsiderTransactionSummary insiderTransactionSummary in insiderTransactionSummaries where insiderTransactionSummary.NumberOfSharesAcquiredDisposed < 0 && insiderTransactionSummary.TransactionDate.Date <= maxBollingerDate && IsVisible(insiderTransactionSummary.TransactionDate.Date) select insiderTransactionSummary).ToList());
+      InsiderTransactionSummaries acquiredSummaries = new InsiderTransactionSummaries((from InsiderTransactionSummary insiderTransactionSummary in insiderTransactionSummaries where insiderTransactionSummary.NumberOfSharesAcquiredDisposed > 0 && insiderTransactionSummary.TransactionDate.Date <= maxBollingerDate && IsVisible(insiderTransactionSummary.TransactionDate.Date) select insiderTransactionSummary).ToList());
 
       BinCollection<InsiderTransactionSummary> disposedSummariesBin = BinHelper<InsiderTransactionSummary>.CreateBins(new BinItems<InsiderTransactionSummary>(disposedSummaries), 3);
       BinCollection<InsiderTransactionSummary> acquiredSummariesBin = BinHelper<InsiderTransactionSummary>.CreateBins(new BinItems<InsiderTransactionSummary>(acquiredSummaries), 3);

PortfolioManager/saveparams.config

@@ -1,12 +1,6 @@
 Type,PortfolioManager.ViewModels.MGSHMomentumViewModel,PathFileName,C:\boneyard\marketdata\Sessions\MGSH20250331.TXT
 Type,PortfolioManager.ViewModels.MomentumViewModel,PathFileName,C:\boneyard\marketdata\Sessions\MG20180131.TXT
 Type,PortfolioManager.ViewModels.CMMomentumViewModel,PathFileName,C:\boneyard\marketdata\Sessions\CM20191031.TXT
-Type,PortfolioManager.ViewModels.CMTrendViewModel,PathFileName,C:\boneyard\marketdata\Sessions\CMT20200817.TXT
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,SPOT,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,False,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,GWRE,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,True,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,CRS,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,True,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,T,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,True,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,NRG,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,False,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,PSO,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,True,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,PARR,SelectedWatchList,Valuations,SelectedDayCount,180,SyncTradeToBand,False,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
-Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,SH,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,False,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
+Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,ALHC,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,True,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True
+Type,PortfolioManager.ViewModels.CMTrendViewModel,PathFileName,C:\boneyard\marketdata\bin\Debug\saferun\CMT20200817.TXT
+Type,PortfolioManager.ViewModels.BollingerBandViewModel,SelectedSymbol,HWM,SelectedWatchList,Valuations,SelectedDayCount,90,SyncTradeToBand,False,ShowTradeLabels,True,UseLeastSquaresFit,True,ShowInsiderTransactions,True,StopHistoryCount,5,StopHistory_0,Symbol=HWM|StopPrice=176.71|Shares=0|StopType=Stop Quote|EffectiveDate=11/17/2025,StopHistory_1,Symbol=HWM|StopPrice=186.778498840332|Shares=0|StopType=Stop Quote|EffectiveDate=11/26/2025,StopHistory_2,Symbol=HWM|StopPrice=193.123001594543|Shares=0|StopType=Stop Quote|EffectiveDate=12/26/2025,StopHistory_3,Symbol=HWM|StopPrice=197.56385799408|Shares=0|StopType=Stop Quote|EffectiveDate=1/26/2026,StopHistory_4,Symbol=HWM|StopPrice=235.233001537323|Shares=0|StopType=Stop Quote|EffectiveDate=2/25/2026